----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16736/#review31428 -----------------------------------------------------------
Ship it! Ship It! - Abhinandan Prateek On Jan. 8, 2014, 1:03 p.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16736/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 1:03 p.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Bugs: CLOUDSTACK-5790 and CLOUDSTACK-5791 > https://issues.apache.org/jira/browse/CLOUDSTACK-5790 > https://issues.apache.org/jira/browse/CLOUDSTACK-5791 > > > Repository: cloudstack-git > > > Description > ------- > > 1. Reverted the commit for encrypting ldap hostname and port > 2. decrypted ldap hostname and port during upgrade as they are not encrypted > now. > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 471307a > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java > 53d3877 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java > caabbe7 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java > 2fb6332 > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java > c2158f4 > setup/db/db/schema-421to430.sql 284fb17 > setup/db/db/schema-421to430.sql 7098632 > > Diff: https://reviews.apache.org/r/16736/diff/ > > > Testing > ------- > > manually > > > Thanks, > > Rajani Karuturi > >
