----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16560/#review31513 -----------------------------------------------------------
engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java <https://reviews.apache.org/r/16560/#comment60023> Remove the other setter just above this. engine/orchestration/src/com/cloud/vm/VmWorkReconfigure.java <https://reviews.apache.org/r/16560/#comment60024> VmWorkReconfigure is a Serializable class. So all members should also be serializable. Check if it is possible to pass the cpu, cpu cores and ram in a different way like using a list/map which is serializable instead of passing ServiceOffering. server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/16560/#comment60025> reorganize as below if (currentServiceOffering.isDynamic()) { if (newServiceOffering.isDynamic()) { saveCustomOfferingDetails(vmId, newServiceOffering); } else { removeCustomOfferingDetails(vmId); } } - Koushik Das On Jan. 10, 2014, 6:33 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16560/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2014, 6:33 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-5711 allow scaling from the same offering when using custom > compute offering. > https://issues.apache.org/jira/browse/CLOUDSTACK-5711 > > > Diffs > ----- > > api/src/com/cloud/vm/VirtualMachineProfile.java 3da8397 > engine/api/src/com/cloud/vm/VirtualMachineManager.java 5e57b85 > engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java > 8282b16 > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > f959b93 > engine/orchestration/src/com/cloud/vm/VmWorkReconfigure.java 1141577 > engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java > 7d55064 > server/src/com/cloud/vm/UserVmManager.java 85322f2 > server/src/com/cloud/vm/UserVmManagerImpl.java 23df880 > server/test/com/cloud/vm/UserVmManagerTest.java 34090ef > > Diff: https://reviews.apache.org/r/16560/diff/ > > > Testing > ------- > > tested on 4.3 > > > Thanks, > > bharat kumar > >
