> On Jan. 20, 2014, 9:42 a.m., Sateesh Chodapuneedi wrote: > > tools/appliance/convert_ovf_vbox_to_esx.xslt, line 20 > > <https://reviews.apache.org/r/17115/diff/1/?file=432661#file432661line20> > > > > vbox specific namespace url could be omitted. > > xmlns:vbox="http://www.virtualbox.org/ovf/machine
Agreed, but the name space does not matter. It a waste of bytes, but should not interfere with working of the imported file. > On Jan. 20, 2014, 9:42 a.m., Sateesh Chodapuneedi wrote: > > tools/appliance/build.sh, line 95 > > <https://reviews.apache.org/r/17115/diff/1/?file=432658#file432658line95> > > > > Thanks for the patch. Can you please share the generated ovf file? You can download the generated OVA from http://jenkins.buildacloud.org/job/build-systemvm-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvmtemplate-2014-01-19-master-vmware.ova It contains the generated ovf in the ova. - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17115/#review32288 ----------------------------------------------------------- On Jan. 20, 2014, 8:59 a.m., Hugo Trippaers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17115/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2014, 8:59 a.m.) > > > Review request for cloudstack and Animesh Chaturvedi. > > > Bugs: CLOUDSTACK-5883 > https://issues.apache.org/jira/browse/CLOUDSTACK-5883 > > > Repository: cloudstack-git > > > Description > ------- > > Virtualbox export creates an OVF file that is not compatible with VMware > import functions. This causes import errors when the systemvm ova is imported > into cloudstack. This patch fixes the issue by using an XSLT transformation > to convert the generated ovf into a format this is compatible with vmware. > > This is a squashed commit Based on the following commits in master: > 794d47c5f279bc8cbd212d9dd87673b8302de9db > bf26efc551e56d21a24049952ebe81f9686df5ec > 5d24843ef59b4d28a9a81ade4510c44b2a048b06 > 95a92ad2e3e7a8ceade4e5cd2e4ebd717c1cc2ab > da8ee45a249f89f2ef2a74d225854b37785f6922 > 50054fe0603673d04655362ea515d3b5c5bb3610 > 50054fe0603673d04655362ea515d3b5c5bb3610 > ecf57c368a9790e28e47bb83b51201763bd2b1ef > > > Diffs > ----- > > tools/appliance/build.sh 61ee793 > tools/appliance/convert/Convert.class PRE-CREATION > tools/appliance/convert/Convert.java PRE-CREATION > tools/appliance/convert_ovf_vbox_to_esx.xslt PRE-CREATION > > Diff: https://reviews.apache.org/r/17115/diff/ > > > Testing > ------- > > Created systemvm using the jenkins build system (master branch) and imported > the systemvm into cloudstack and created an instance based on these > templates. (32 and 64 bit) > > > Thanks, > > Hugo Trippaers > >
