-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17233/
-----------------------------------------------------------
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-5875
https://issues.apache.org/jira/browse/CLOUDSTACK-5875
Repository: cloudstack-git
Description
-------
Fixed the issue CLOUDSTACK-5875
The crash issue happens because of null value for CallContext.current() under
discoverHostsFull, when called from thread for SystemVMHandler. Currently,
there is no call context set for this thread. Currently, as part of
MockAgentManagerImpl.java, SystemVMHandler implements Runnable, but when it
calls discoverHosts, it does not have any call context set and it is crashing.
Because of which agent was not coming up and template sync and resource
discovery failed. Added a register and unregister of callcontext of system user
for this thread.
2. There was a new column added by name "state" under "vm_templates" table. The
value of this column for "Active" was checked for listing the templates if
there was no removed attribute set for list templates api. This column was not
present in 4.2. Added a column value "Active" for simulator schema. The value
of this column was not Active and so listing failed.
Testing:
1. Built the CS using the changes. Tested the column value, post deploydb and
it was now set to "Active". Deployed a DC and list template works.
2. Deploy DC worked fine with simulator . Created an instance using the
template and it worked to start. Agent for systemvm was coming up.
Note:
1. For listing templates, a hypervisor in the zone need to be present because
listtemplates api is looking for it. Use the list templates post the deployDC
and it works.
2. We need to set router.version.check to false under global properties of CS
post run using simulator. Otherwise you may see errors related to router
upgrade etc. This i believe is a known issue and nothing to do with simulator.
3. Post the changes, tested only with simulator.
3. Also, please change the component field. AS such it is not related to Marvin.
Diffs
-----
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockAgentManagerImpl.java
4071aeb
setup/db/templates.simulator.sql 5f9b67d
Diff: https://reviews.apache.org/r/17233/diff/
Testing
-------
Testing:
1. Built the CS 4.3-forward using the changes. Tested the column value change,
post deploydb and it was now set to "Active". Deployed a DC and list template
works.
2. Deploy DC worked fine with simulator . Created an instance using the
template and it worked to start. Agent for systemvm was coming up.
Note:
1. For listing templates, a hypervisor in the zone need to be present because
listtemplates api is looking for it. Use the list templates post the deployDC
and it works.
2. We need to set router.version.check to false under global properties of CS
post run using simulator. Otherwise you may see errors related to router
upgrade etc. This i believe is a known issue and nothing to do with simulator.
3. Post the changes, tested only with simulator.
Thanks,
Santhosh Edukulla
