-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17452/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-5963
https://issues.apache.org/jira/browse/CLOUDSTACK-5963
Repository: cloudstack-git
Description
-------
1. The way we are verifying the response for test_public_ip_admin_account seems
to have an issue, it should ideally check for empty list.
2. Post the nat and firewall rule, still there could be a possibility such that
the vm may not be in running state. We are not passing mode flag here as such
for advanced zone. So explicit fail when vm status is not running post the ssh
failure.
3. try except block for nat rule deletion and listing.
4. Adding a sleep post delete.
Diffs
-----
test/integration/smoke/test_network.py 732fe15
Diff: https://reviews.apache.org/r/17452/diff/
Testing
-------
Testing on private branch post other changes pending, tested locally.
Thanks,
Santhosh Edukulla
