----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17348/#review33274 -----------------------------------------------------------
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java <https://reviews.apache.org/r/17348/#comment62673> I just notice that you didn't follow Java function/variable style. The first character of variable/functions should be lower case. You may want to use refactor function of IDE to correct them all(but send in an separate patch for the existed file please). Others looks good to me. Please correct the name style issue in this patch, rebase to latest master and generate the patch using: git-format-patch. Thanks. - Sheng Yang On Jan. 25, 2014, 1:26 a.m., Suresh Balineni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17348/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2014, 1:26 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > VPC Element implementation in contrail plugin > > > Diffs > ----- > > api/src/com/cloud/network/Network.java 62151a4 > > plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml > 4614af7 > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java > 704dedd > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java > 6853d1e > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java > ef76e4c > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVpcElementImpl.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java > b1f4718 > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java > 8ec2ff7 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9d148fa > server/src/com/cloud/network/vpc/VpcManagerImpl.java 2face90 > > Diff: https://reviews.apache.org/r/17348/diff/ > > > Testing > ------- > > This has been verified in 4.3 and porting the same in master branch > > > Thanks, > > Suresh Balineni > >
