Paul, 

  AddImageStore is a new API added in 4.2, it has been designed like that to 
handle different meta information required by different image store provider. 
This API does not have any backwards compatibility issue.  I was never aware of 
any community consensus to pass extra detail information for our API. Actually 
I followed the pattern used in existing APIs. I agee with you that This way to 
pass hash like detail information is indeed cumbersome, the better way is to 
use JSON body instead of putting everything as query parameters for such 
varying detail information.

Thanks
-min

Sent from my iPhone

> On Feb 12, 2014, at 6:37 AM, "Paul Angus" <paul.an...@shapeblue.com> wrote:
> 
> In the case of hyper-v - technically no, as it's a new feature to 4.3 it only 
> breaks 'beta' versiosn of 4.3
> 
> In the case of addimagestore - I'm not sure how long that's been there, I 
> came across it because I've just recently been testing S3 as secondary 
> storage.
> 
> 
> My initial query was around whether this use of 'details' with key/value 
> pairs is a community decision that we're going to start seeing more of and 
> that I/we end users need to understand and adapt to.
> 
> 
> Regards,
> 
> Paul Angus
> Cloud Architect
> S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
> paul.an...@shapeblue.com
> 
> -----Original Message-----
> From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> Sent: 12 February 2014 14:19
> To: dev@cloudstack.apache.org
> Subject: RE: API Calls with key value pairs (Details)
> 
> I think that what Paul was saying. Scripts that have run no longer do.
> 
> I don't think they are scripts written only in 4.3 environments either but I 
> could be wrong.
> 
> 
> Regards
> 
> Alex Hitchins
> 
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M: +44 7788 423 969
> 
> alex.hitch...@shapeblue.com
> 
> -----Original Message-----
> From: Chip Childers [mailto:chipchild...@apache.org]
> Sent: 12 February 2014 14:13
> To: dev@cloudstack.apache.org
> Subject: Re: API Calls with key value pairs (Details)
> 
>> On Wed, Feb 12, 2014 at 8:24 AM, Devdeep Singh <devdeep.si...@citrix.com> 
>> wrote:
>> The user name and password were never there in the key value pair for 
>> creating storage pool. This was done for adding smb as a primary storage and 
>> was done in 4.3 (adding smb as a pool type wasn't available in earlier 
>> release).
>> 
>> Initially user details were passed in the url query string (for smb). 
>> However, it would mean adding a password with special characters could fail 
>> if the password wasn't encoded and then the entire url encoded again. So I 
>> updated it to pass smb user information in details. This is required only if 
>> a storage pool being added is of type smb.
>> 
>> Regards,
>> Devdeep
> 
> Except it breaks backward compat, right?
> Need Enterprise Grade Support for Apache CloudStack?
> Our CloudStack Infrastructure 
> Support<http://shapeblue.com/cloudstack-infrastructure-support/> offers the 
> best 24/7 SLA for CloudStack Environments.
> 
> Apache CloudStack Bootcamp training courses
> 
> **NEW!** CloudStack 4.2.1 training<http://shapeblue.com/cloudstack-training/>
> 18th-19th February 2014, Brazil. 
> Classroom<http://shapeblue.com/cloudstack-training/>
> 17th-23rd March 2014, Region A. Instructor led, 
> On-line<http://shapeblue.com/cloudstack-training/>
> 24th-28th March 2014, Region B. Instructor led, 
> On-line<http://shapeblue.com/cloudstack-training/>
> 16th-20th June 2014, Region A. Instructor led, 
> On-line<http://shapeblue.com/cloudstack-training/>
> 23rd-27th June 2014, Region B. Instructor led, 
> On-line<http://shapeblue.com/cloudstack-training/>
> 
> This email and any attachments to it may be confidential and are intended 
> solely for the use of the individual to whom it is addressed. Any views or 
> opinions expressed are solely those of the author and do not necessarily 
> represent those of Shape Blue Ltd or related companies. If you are not the 
> intended recipient of this email, you must neither take any action based upon 
> its contents, nor copy or show it to anyone. Please contact the sender if you 
> believe you have received this email in error. Shape Blue Ltd is a company 
> incorporated in England & Wales. ShapeBlue Services India LLP is a company 
> incorporated in India and is operated under license from Shape Blue Ltd. 
> Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
> operated under license from Shape Blue Ltd. ShapeBlue is a registered 
> trademark.
> This email and any attachments to it may be confidential and are intended 
> solely for the use of the individual to whom it is addressed. Any views or 
> opinions expressed are solely those of the author and do not necessarily 
> represent those of Shape Blue Ltd or related companies. If you are not the 
> intended recipient of this email, you must neither take any action based upon 
> its contents, nor copy or show it to anyone. Please contact the sender if you 
> believe you have received this email in error. Shape Blue Ltd is a company 
> incorporated in England & Wales. ShapeBlue Services India LLP is a company 
> incorporated in India and is operated under license from Shape Blue Ltd. 
> Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
> operated under license from Shape Blue Ltd. ShapeBlue is a registered 
> trademark.

Reply via email to