----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18072/ -----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers. Repository: cloudstack-git Description ------- Fixing 11 scary and 1 of concern issues found by FindBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class. Diffs ----- plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java 99d0a12 plugins/event-bus/inmemory/test/org/apache/cloudstack/mom/inmemory/InMemoryEventBusTest.java PRE-CREATION utils/src/com/cloud/utils/UuidUtils.java 7831bea utils/test/com/cloud/utils/UuidUtilsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/18072/diff/ Testing ------- Build successfully and added 13 unit tests Thanks, Wilder Rodrigues
