I discarded my review request, based on this:
Harikrishna Patnala commented on CLOUDSTACK-5079:
-------------------------------------------------
Hi Yichi Lu,
This was fixed on NOV 15th and the fix is to use the configDepot class to
populate the scoped variables. This class was introduced as part of new
configuration parameters framework added in 4.3.
Thanks,
Harikrishna
and this:
Srikanteswararao Talluri (JIRA)
Jan 31 (13 days ago)
to me
[ https://issues.apache.org/jira/browse/CLOUDSTACK-5079
?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Srikanteswararao Talluri closed CLOUDSTACK-5079.
On Thu, Feb 13, 2014 at 12:33 PM, Amogh Vasekar <amogh.vase...@citrix.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15633/
>
> Reminder -
> This review has been pending for long. Request the submitter to please add
> relevant reviewers or seek volunteers from the community.
> Thanks!
>
>
>
> - Amogh Vasekar
>
> On November 17th, 2013, 10:29 p.m. UTC, Yichi Lu wrote:
> Review request for cloudstack.
> By Yichi Lu.
>
> *Updated Nov. 17, 2013, 10:29 p.m.*
> *Bugs: * 5079 <https://issues.apache.org/jira/browse/5079>
> *Repository: * cloudstack-git
> Description
>
> CLOUDSTACK-5079. When using api call, listConfigurations, and specifying
> clusterid, some keys may not have values. this causes a null pointer to be
> returned.
> Add guard against null pointer in
> server/src/com/cloud/server/ConfigurationServerImpl.java::getConfigListByScope().
> If a null pointer is returned from
> framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java::get(),
> set value to 'NULL'.
>
> Testing
>
> tested api calls for &listConfigurations, &listConfigurations&clusterid=xxx,
> &listConfigurations&zoneid=xxx, &listConfigurations&category=Advanced
>
> Diffs
>
> - server/src/com/cloud/server/ConfigurationServerImpl.java (8459ada)
>
> View Diff <https://reviews.apache.org/r/15633/diff/>
>
