-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18077/#review34471
-----------------------------------------------------------
Ship it!
commit 79c4905fd26d6a867f930db338231f68511fa209
Author: Alex Hitchins <a...@alexhitchins.com>
Date: Mon Feb 10 15:27:47 2014 +0000
Findbugs - Long equality fix.
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
commit c36c7e7de60cd1eb8310d16045dffb9df2105ada
Author: Alex Hitchins <a...@alexhitchins.com>
Date: Wed Feb 12 10:30:54 2014 +0000
AJH Findbugs [8] - Added .toString() to enum.
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
commit 30672bfe19e3959428f860222126deb31fb899d1
Author: Alex Hitchins <a...@alexhitchins.com>
Date: Wed Feb 12 10:52:02 2014 +0000
AJH Findbugs [9] - Added object to map rather than string
Signed-off-by: Hugo Trippaers <htrippa...@schubergphilis.com>
- Hugo Trippaers
On Feb. 13, 2014, 1:31 p.m., Alexander Hitchins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18077/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 1:31 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Findbugs Patches
>
>
> Diffs
> -----
>
>
> plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
> b82b361
> server/src/com/cloud/network/NetworkModelImpl.java 52a08e1
> server/src/com/cloud/network/guru/ControlNetworkGuru.java a6e2180
>
> Diff: https://reviews.apache.org/r/18077/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Hitchins
>
>
