-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18113/
-----------------------------------------------------------
(Updated Feb. 14, 2014, 11:48 a.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Add license headers to new files
Repository: cloudstack-git
Description
-------
Fix findbugs findings in cloud-plugin-network-elb
Findings:
- comparing Longs by reference
- possible null pointer dereference
Diffs (updated)
-----
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 8b4433e
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java
6dd0f8a
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/LoadBalanceRuleHandler.java
PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/ElasticLoadBalancerManagerImplTest.java
PRE-CREATION
plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/LoadBalanceRuleHandlerTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/18113/diff/
Testing
-------
Added unit tests the changes in the patch and tested in DevCloud.
Thanks,
Miguel Ferreira
