----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18165/ -----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers. Repository: cloudstack-git Description ------- Fixed 2 equals() method implementations Added synchronized keyword to a get() method, because the set() is already synchronized Commented out a dead variable Diffs ----- engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java 3ebaf4a engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentAttache.java 23c3f76 engine/orchestration/src/com/cloud/agent/manager/ConnectedAgentAttache.java 00d54bb engine/orchestration/src/org/apache/cloudstack/engine/service/api/ProvisioningServiceImpl.java 86eab58 engine/orchestration/test/com/cloud/agent/manager/ConnectedAgentAttacheTest.java PRE-CREATION Diff: https://reviews.apache.org/r/18165/diff/ Testing ------- Check style successfully executed; Build successfully executed 5 unit tests added in order to cover the changes. Thanks, Wilder Rodrigues
