> On Feb. 17, 2014, 8:49 a.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/integration/lib/common.py, line 937 > > <https://reviews.apache.org/r/18117/diff/2/?file=485190#file485190line937> > > > > All other seems to be ok, only one request here is not to raise asserts > > in library method, use try\except block and assert in the test case based > > upon outcome. > > Also, please attach test case run log.
Added log and separated the assertions in the test case instead of in library method. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18117/#review34639 ----------------------------------------------------------- On Feb. 17, 2014, 1:20 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18117/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 1:20 p.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-4840 > https://issues.apache.org/jira/browse/CLOUDSTACK-4840 > > > Repository: cloudstack-git > > > Description > ------- > > Adding first set of test cases for feature "Multiple IPs per NICs". > > > Diffs > ----- > > test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION > tools/marvin/marvin/codes.py 74fb05d > tools/marvin/marvin/integration/lib/base.py aa23029 > tools/marvin/marvin/integration/lib/common.py e202391 > > Diff: https://reviews.apache.org/r/18117/diff/ > > > Testing > ------- > > test_add_ip_to_nic_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations) > Add secondary IP to NIC of a VM ... ok > test_add_ip_to_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations) > Add secondary IP to NIC of a VM ... ok > test_add_ip_to_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations) > Add secondary IP to NIC of a VM ... ok > test_list_nics_ISOLATED (test_multiple_ips_per_nic.TestBasicOperations) > Test listing nics associated with the ip address ... ok > test_list_nics_SHARED (test_multiple_ips_per_nic.TestBasicOperations) > Test listing nics associated with the ip address ... ok > test_list_nics_VPC (test_multiple_ips_per_nic.TestBasicOperations) > Test listing nics associated with the ip address ... ok > test_operations_non_root_admin_api_client_ISOLATED > (test_multiple_ips_per_nic.TestBasicOperations) > Test basic operations using non root admin apii client ... ok > test_operations_non_root_admin_api_client_SHARED > (test_multiple_ips_per_nic.TestBasicOperations) > Test basic operations using non root admin apii client ... ok > test_operations_non_root_admin_api_client_VPC > (test_multiple_ips_per_nic.TestBasicOperations) > Test basic operations using non root admin apii client ... ok > test_remove_invalid_ip (test_multiple_ips_per_nic.TestBasicOperations) > Remove invalid ip ... ok > test_remove_ip_from_nic_ISOLATED > (test_multiple_ips_per_nic.TestBasicOperations) > Remove secondary IP from NIC of a VM ... ok > test_remove_ip_from_nic_SHARED (test_multiple_ips_per_nic.TestBasicOperations) > Remove secondary IP from NIC of a VM ... ok > test_remove_ip_from_nic_VPC (test_multiple_ips_per_nic.TestBasicOperations) > Remove secondary IP from NIC of a VM ... ok > > ---------------------------------------------------------------------- > Ran 13 tests in 4170.915s > > OK > > > Thanks, > > Ashutosh Kelkar > >
