----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18894/ -----------------------------------------------------------
(Updated March 7, 2014, 6:10 a.m.) Review request for cloudstack, Abhinandan Prateek and Ian Duffy. Bugs: CLOUDSTACK-6210 https://issues.apache.org/jira/browse/CLOUDSTACK-6210 Repository: cloudstack-git Description ------- This occurs when ldap basedn is not configured. Throwing an IAE and a proper message is returned from the api call The api call response earlier was { "ldapuserresponse" : {"uuidList":[],"errorcode":530,"cserrorcode":9999} } now it is as follows { "ldapuserresponse" : {"uuidList":[],"errorcode":431,"cserrorcode":9999,"errortext":"ldap basedn is not configured"} } Diffs ----- plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 2dacafe plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy fa735d3 Diff: https://reviews.apache.org/r/18894/diff/ Testing ------- unittested by adding a new test case "test searchUsers when ldap basedn in not set" in LdapUserManagerSpec.groovy which reproduces this case manually tested the api call as well Thanks, Rajani Karuturi