That sounds good, Daan. Let's use both tags.
Thanks! On Fri, Mar 7, 2014 at 9:33 AM, Daan Hoogland <daan.hoogl...@gmail.com>wrote: > Absolutaly, > > But I meant for us to use both tags. I checked in a commit (that I > didn't give a head up on) for a colleague in which a > CloudRuntimeException was removed to be more consistent with the rest > of the code. It was only effecting th upgrade process in this case but > still; > [BEHAVIORAL-CHANGE] was caused. Of course these heads-up will always > be an inter developer courtesy but here is mine (hidden in some one > elses thread;) > > so in short i meant and and not or, > Daan > > > On Fri, Mar 7, 2014 at 4:20 PM, Mike Tutkowski > <mike.tutkow...@solidfire.com> wrote: > > I like either tag. > > > > Since DB changes are the most likely to lead to breaking other people's > > environments, maybe we should go with that one: > > > > [DB-CHANGE] > > > > Ideally we'd provide the branch, commit SHA, and a manual way around it, > if > > there is something simple (like in my case yesterday, simply deleting and > > re-creating two views). If there's no easy way around it, then don't > bother > > providing that. > > > > Sound reasonable? > > > > > > On Fri, Mar 7, 2014 at 2:12 AM, Daan Hoogland <daan.hoogl...@gmail.com > >wrote: > > > >> Thanks for the heads up Mike, > >> > >> As discussed in your thread [1]. You are eating your own dogfood here. > >> I was checking in a minor change to the upgrade handling yesterday and > >> decided not to bother everyone with it. evil me. In that thread we > >> didn't dicide on a tag, yet. > >> > >> I would suggest > >> [DB-CHANGE] and > >> [BEHAVIORAL-CHANGE] > >> > >> [1] http://markmail.org/message/r7wv36o356nolq7f > >> > >> On Thu, Mar 6, 2014 at 9:05 PM, Mike Tutkowski > >> <mike.tutkow...@solidfire.com> wrote: > >> > Hi everyone, > >> > > >> > Just wanted to give you a heads up that I made a minor change to two > >> views > >> > in the DB in 9b66866dc2085486f465159cbd446ac03e266a2c: > >> > > >> > service_offering_view and disk_offering_view > >> > > >> > I added some columns to these views so I could present additional > info in > >> > the GUI. > >> > > >> > If you want to bring these two views up to date, just run the > following > >> SQL: > >> > > >> > DROP VIEW IF EXISTS `cloud`.`disk_offering_view`; > >> > CREATE VIEW `cloud`.`disk_offering_view` AS > >> > select > >> > disk_offering.id, > >> > disk_offering.uuid, > >> > disk_offering.name, > >> > disk_offering.display_text, > >> > disk_offering.disk_size, > >> > disk_offering.min_iops, > >> > disk_offering.max_iops, > >> > disk_offering.created, > >> > disk_offering.tags, > >> > disk_offering.customized, > >> > disk_offering.customized_iops, > >> > disk_offering.removed, > >> > disk_offering.use_local_storage, > >> > disk_offering.system_use, > >> > disk_offering.hv_ss_reserve, > >> > disk_offering.bytes_read_rate, > >> > disk_offering.bytes_write_rate, > >> > disk_offering.iops_read_rate, > >> > disk_offering.iops_write_rate, > >> > disk_offering.cache_mode, > >> > disk_offering.sort_key, > >> > disk_offering.type, > >> > disk_offering.display_offering, > >> > domain.id domain_id, > >> > domain.uuid domain_uuid, > >> > domain.name domain_name, > >> > domain.path domain_path > >> > from > >> > `cloud`.`disk_offering` > >> > left join > >> > `cloud`.`domain` ON disk_offering.domain_id = domain.id > >> > where > >> > disk_offering.state='ACTIVE'; > >> > > >> > DROP VIEW IF EXISTS `cloud`.`service_offering_view`; > >> > CREATE VIEW `cloud`.`service_offering_view` AS > >> > select > >> > service_offering.id, > >> > disk_offering.uuid, > >> > disk_offering.name, > >> > disk_offering.display_text, > >> > disk_offering.created, > >> > disk_offering.tags, > >> > disk_offering.removed, > >> > disk_offering.use_local_storage, > >> > disk_offering.system_use, > >> > disk_offering.customized_iops, > >> > disk_offering.min_iops, > >> > disk_offering.max_iops, > >> > disk_offering.hv_ss_reserve, > >> > disk_offering.bytes_read_rate, > >> > disk_offering.bytes_write_rate, > >> > disk_offering.iops_read_rate, > >> > disk_offering.iops_write_rate, > >> > disk_offering.cache_mode, > >> > service_offering.cpu, > >> > service_offering.speed, > >> > service_offering.ram_size, > >> > service_offering.nw_rate, > >> > service_offering.mc_rate, > >> > service_offering.ha_enabled, > >> > service_offering.limit_cpu_use, > >> > service_offering.host_tag, > >> > service_offering.default_use, > >> > service_offering.vm_type, > >> > service_offering.sort_key, > >> > service_offering.is_volatile, > >> > service_offering.deployment_planner, > >> > domain.id domain_id, > >> > domain.uuid domain_uuid, > >> > domain.name domain_name, > >> > domain.path domain_path > >> > from > >> > `cloud`.`service_offering` > >> > inner join > >> > `cloud`.`disk_offering` ON service_offering.id = > >> disk_offering.id > >> > left join > >> > `cloud`.`domain` ON disk_offering.domain_id = domain.id > >> > where > >> > disk_offering.state='Active'; > >> > > >> > Thanks! > >> > > >> > -- > >> > *Mike Tutkowski* > >> > *Senior CloudStack Developer, SolidFire Inc.* > >> > e: mike.tutkow...@solidfire.com > >> > o: 303.746.7302 > >> > Advancing the way the world uses the > >> > cloud<http://solidfire.com/solution/overview/?video=play> > >> > *(tm)* > >> > >> > >> > >> -- > >> Daan > >> > > > > > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkow...@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the > > cloud<http://solidfire.com/solution/overview/?video=play> > > *(tm)* > > > > -- > Daan > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play> *(tm)*
