----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/#review37723 -----------------------------------------------------------
test/integration/component/test_usage.py <https://reviews.apache.org/r/19399/#comment69370> Also, just a thought. If stop operation itself verifies the state and return, so test case can check some thing like if virtual_machine.stop() == FAIL: raise\fail. I believe we can use getState inside stop operation itself. Basically, stop operation return can be enforced and checked. tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/19399/#comment69366> Add other states for VM as well. If anybody wanted to use it, they can use these states, otherwise they have to touch this library again. tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/19399/#comment69368> Move this inside try block. tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/19399/#comment69369> Just reorganize while loop, and use while timeout rather than while True. So, we dont need separate elif. tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/19399/#comment69364> This else can be removed i believe. Also , continue is not required. - Santhosh Edukulla On March 19, 2014, 3:10 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19399/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 3:10 p.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6257 > https://issues.apache.org/jira/browse/CLOUDSTACK-6257 > > > Repository: cloudstack-git > > > Description > ------- > > As suggested, added getState method for VirtualMachine class, and it is > called before template creation. If VM fails to go into desired state, it > returns failure. > > > Diffs > ----- > > test/integration/component/test_project_usage.py ba0a63c > test/integration/component/test_resource_limits.py f0d558e > test/integration/component/test_tags.py 2a6e076 > test/integration/component/test_templates.py 3e83615 > test/integration/component/test_usage.py 5979a0a > tools/marvin/marvin/integration/lib/base.py 775b289 > > Diff: https://reviews.apache.org/r/19399/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > >
