> On March 21, 2014, 10:11 a.m., Murali Reddy wrote:
> > change look good. But patch does not apply on master. Could you please
> > upload proper patch?
> >
> > Also current patch fixes only action events, do you wish to add similar
> > logic for alerts and usage events as well?
I am attaching the latest patch file, the changes should work for all
categories of event like
EventCategory("ActionEvent");
EventCategory("AlertEvent");
EventCategory("UsageEvent");
EventCategory("ResourceStateEvent");
EventCategory("AsyncJobEvent");
- Sonal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review38080
-----------------------------------------------------------
On March 24, 2014, 7:23 a.m., Sonal Ojha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 7:23 a.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3272
> https://issues.apache.org/jira/browse/CLOUDSTACK-3272
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> At present, there are multiple event types that are generated by CS, action
> events,usage events, resource state change events and alerts. Current problem
> is
> all the events gets published on the event bus when event bus is enabled.
> Intent is to introduce global setting config parameters to specify which
> category of events to be published or not be published on the event bus.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/Config.java 2d55f46
> server/src/com/cloud/event/ActionEventUtils.java 00122de
> server/src/com/cloud/test/DatabaseConfig.java 9370218
>
> Diff: https://reviews.apache.org/r/18677/diff/
>
>
> Testing
> -------
>
> Successfully tested publishing / not publishing of various events based on
> the global parameter publish.*.events.
>
>
> File Attachments
> ----------------
>
> Latest Patch File
>
> https://reviews.apache.org/media/uploaded/files/2014/03/24/a0a6c3ab-d756-4c79-9730-2acf9d1b0dea__0001-CLOUDSTACK-3272-Changes-to-allow-publishing-of-event.patch
>
>
> Thanks,
>
> Sonal Ojha
>
>
