> On March 18, 2014, 6:35 p.m., Alena Prokharchyk wrote: > > Even for the Basic zone, we should send the ipSet command on nicplug only > > when the SG is supported by the Basic zone network. Because we also support > > a model when Basic zone is deployed with SG disabled.
When vm is created vm primary ip is set in ipset. For nic secondary ip there is no nicplug command send to hypervisor. - Jayapal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19351/#review37596 ----------------------------------------------------------- On March 19, 2014, 11:59 a.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19351/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 11:59 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and edison su. > > > Bugs: CLOUDSTACK-6240 > https://issues.apache.org/jira/browse/CLOUDSTACK-6240 > > > Repository: cloudstack-git > > > Description > ------- > > Updated adding SG rules for nic secondary ips in Advacned SG. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java > b5e2239 > api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java > 199cf2e > server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 51c93b7 > > Diff: https://reviews.apache.org/r/19351/diff/ > > > Testing > ------- > > Tested 'ipset -L' output on xenserver after acquiring secondary ip for vm nic > > > Thanks, > > Jayapal Reddy > >
