Axel, did you change this already submitted change request? Or did you reuse the entry in the review boar to create a new review request? In both cases I'd rather have you close this one and create a new one.
On Thu, Apr 3, 2014 at 6:51 PM, Axel Delahaye <axel.delah...@worldline.com>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16688/ > Review request for cloudstack. > By Axel Delahaye. > > *Updated April 3, 2014, 4:51 p.m.* > Changes > > I added the '<' and '>' char to the french keyboard for console proxy > > *Repository: * cloudstack-git > Description > > Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in > ajaxviwer.js. > altgr : <altgr state match condition>, -- match on altgr state > > It works like the shift match condition. > shift : <shift state match condition>, -- match on shift state > > Browser can't detect difference between AltGr and Ctrl+Alt pressed at the > same time. > So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr > key and 'altgr' condition will be true. > > In the ajaxkey.js file you got for example: > {type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true} > to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key > > Secondly, > I wrote the French AZERTY translation table in ajaxkeys.js with the support > of AltGr character (like #{}[]|,etc.) > > For example the '#': > > {keycode: 51, entry: [ //User type the "3# key and each condition > match 'altgr' > {type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC > AltGR key > {type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true}, //press the 3 key > {type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it > {type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true} //release the > AltGr key > ]}, > > I replace the Standard (US) keyboard translation table because I can't add an > entry in the console proxy keyboard menu. > > Thanks for watching my work > > Axel Delahaye > > Testing > > Tested with > Hardware : French AZERTY keyboard > Software : Configured in windows as FR keyboard > Console-proxy : Customized Standard (US) keyboard > Guest : CentOS 6.5 , Debian 7 and FreeBSD 8 > Guest keymap : fr, fr-pc > > Only the "<" ">" key doesn't work > > Diffs (updated) > > - services/console-proxy/server/js/ajaxkeys.js (abe6f13) > > View Diff <https://reviews.apache.org/r/16688/diff/> > -- Daan
