Sorry - I picked that up but must have been after I'd done the patch. Will amend _again_!
Alex Hitchins | 07788 423 969 | 01892 523 587 --------------------------------------------- -----Original Message----- From: daan Hoogland [mailto:nore...@reviews.apache.org] On Behalf Of daan Hoogland Sent: 15 April 2014 15:07 To: daan Hoogland Cc: Alex Hitchins; cloudstack Subject: Re: Review Request 19616: Added check for null return. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19616/#review40390 ----------------------------------------------------------- server/src/com/cloud/storage/VolumeApiServiceImpl.java <https://reviews.apache.org/r/19616/#comment73373> calling equals(null) on an object will never return true. It will throw a npe or return false. Do you mean to fix this? - daan Hoogland On April 15, 2014, 10:18 a.m., Alex Hitchins wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19616/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 10:18 a.m.) > > > Review request for cloudstack and daan Hoogland. > > > Repository: cloudstack-git > > > Description > ------- > > Added check for returned null, if received then throw exception. > > Amendments made as per dev mailing list comments. > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeApiServiceImpl.java 680cd2e > > Diff: https://reviews.apache.org/r/19616/diff/ > > > Testing > ------- > > Compiled & ran. > > > Thanks, > > Alex Hitchins > >
