----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20445/#review41164 -----------------------------------------------------------
Ship it! Ship It! - Frank Zhang On April 17, 2014, 9:41 a.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20445/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 9:41 a.m.) > > > Review request for cloudstack, Alex Huang, Frank Zhang, and Hugo Trippaers. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6435 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6435 > > > Repository: cloudstack-git > > > Description > ------- > > Currently the python script "setup/bindir/cloud-setup-databases.in" for setup > databases uses template based parameters which will get replaced during rpm > build. > Along with this also enable new command line options to over ride those > template based parameters if the same get passed as command line options. > Accept the following options: > 1. db-conf-path > 2. db-files-path > 3. encryption-jar-path > 4. encryption-key-file > Also replace code that calls OS specific commands with python specific > libraries. > > > Diffs > ----- > > setup/bindir/cloud-setup-databases.in 2ba7d51 > > Diff: https://reviews.apache.org/r/20445/diff/ > > > Testing > ------- > > Tested the script on both windows and linux environment > > Tested for the following scenarios > > 1. With out passing new options on linux environment > 2. With passing new options on linux environment > 3. With passing new options on windows environment > 4. With out passing new options on windows environment (Script fails here as > there are no replacements happened for template parameters during build) > > > Thanks, > > Damodar Reddy Talakanti > >
