> On April 1, 2014, 1:33 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_base_image_updation.py, line 648 > > <https://reviews.apache.org/r/19119/diff/1/?file=517302#file517302line648> > > > > This will always fail if not through assert. Is that our intention to > > fail always? > > > > Also, we dont require an assert and fail in sequence. Use one of them.
Please check against the issue raised. As well, verify that it works on current master? - Santhosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19119/#review39152 ----------------------------------------------------------- On March 12, 2014, 1:38 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19119/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 1:38 p.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5887 > https://issues.apache.org/jira/browse/CLOUDSTACK-5887 > > > Repository: cloudstack-git > > > Description > ------- > > The test case was failing while checking snapshot policies. In case the > volume is deleted, snapshot policy won't list but if the volumes is not yet > deleted, in that case snapshot policy list will be empty. > We should be checking both these conditions. > > > Diffs > ----- > > test/integration/component/test_base_image_updation.py af968cc > > Diff: https://reviews.apache.org/r/19119/diff/ > > > Testing > ------- > > Yes. > > Log: > Test deploy an instance with service offerings with IsVolatile set. ... SKIP: > skip > Test rebooting instances created with isVolatile service offerings ... SKIP: > skip > Test restoring a vm with different template than the one it was created with > ... SKIP: skip > Create a VM using the Service offering IsVolatile enabled ... ok > > ---------------------------------------------------------------------- > Ran 4 tests in 1441.368s > > OK (SKIP=3) > > > Thanks, > > Gaurav Aradhye > >
