Lucian, Did you apply it? Or just approved?
On Mon, May 5, 2014 at 8:19 PM, Nux Ro <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20921/#review42174 > ----------------------------------------------------------- > > Ship it! > > > Ship It! > > - Nux Ro > > > On April 30, 2014, 10:24 p.m., David Bierce wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/20921/ >> ----------------------------------------------------------- >> >> (Updated April 30, 2014, 10:24 p.m.) >> >> >> Review request for cloudstack. >> >> >> Bugs: CLOUDSTACK-6552 >> https://issues.apache.org/jira/browse/CLOUDSTACK-6552 >> >> >> Repository: cloudstack-git >> >> >> Description >> ------- >> >> The RPM build cloud.spec creates a directory that is never used by >> cloudstack management and is just left as an empty directory name >> cloudstack-management in /var/log. >> >> >> Diffs >> ----- >> >> packaging/centos63/cloud.spec 83c598b >> >> Diff: https://reviews.apache.org/r/20921/diff/ >> >> >> Testing >> ------- >> >> Build RPMs on CentOS 6.4 and 6.5 using master >> >> mvn clean install -Dnonoss -Dnoredist >> package.sh -p noredist >> >> Resulting packages installed on Centos 6.5 without the unused directory. >> >> >> Thanks, >> >> David Bierce >> >> > -- Daan
