----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22249/#review44781 -----------------------------------------------------------
Ship it! Ship It! - Nitin Mehta On June 4, 2014, 10:37 p.m., Amogh Vasekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22249/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 10:37 p.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: CLOUDSTACK-6358 > https://issues.apache.org/jira/browse/CLOUDSTACK-6358 > > > Repository: cloudstack-git > > > Description > ------- > > Remove hardcoded guest OS mapping for vmware, as a part of supporting dynamic > addition of guest OS. > > > Diffs > ----- > > > engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java > 21f4968ca7657a35d19e2bad62a503d2fadd21ec > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 77c45b26b7d50f2dedfe6e46d534ea3b82e8f75f > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 52421fa4406991446ce5c8970e853abea96ceee4 > > Diff: https://reviews.apache.org/r/22249/diff/ > > > Testing > ------- > > This patch is for vmware > 1. Local testing on VMware > 2. Successfully got up system VMs > 3. Successfully created a CentOS VM > > > Thanks, > > Amogh Vasekar > >
