----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22727/#review46263 -----------------------------------------------------------
Commit 918c320438980f070150f872e3a3ba907572af83 in cloudstack's branch refs/heads/master from Upendra Moturi [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=918c320 ] CLOUDSTACK-6847.Link.java and console proxy files have hardcoded value - ASF Subversion and Git Services On June 20, 2014, 10:02 a.m., upendra moturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22727/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 10:02 a.m.) > > > Review request for cloudstack and daan Hoogland. > > > Bugs: CLOUDSTACK-6847 > https://issues.apache.org/jira/browse/CLOUDSTACK-6847 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6847.Link.java and ConsoleProxySecureServerFactoryImpl.java have > hardcoded value "vmops.com" which is used as a passphrase for keystore > (cloud.keystore). > It mean when generating jks file from certs we need to use this as passphrase. > Changed the code to get those values form properties file. > > Changed all files to my knowledge . > > > Diffs > ----- > > client/tomcatconf/db.properties.in b224cec > > services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxySecureServerFactoryImpl.java > 81d623a > setup/bindir/cloud-setup-encryption.in cf27b37 > utils/src/com/cloud/utils/nio/Link.java 0767815 > > Diff: https://reviews.apache.org/r/22727/diff/ > > > Testing > ------- > > Did basic testing. > > > Thanks, > > upendra moturi > >