----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22256/#review49098 -----------------------------------------------------------
Commit 8b9166ae0bf437f35bf51dfb8dcfda3e4835a8ee in cloudstack's branch refs/heads/4.4 from Anshul Gangwar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8b9166a ] CLOUDSTACK-6830: Fixed [hyper-v] during VM migration, volumes on zone wide primary store requires storage migration resulting in failure of VM migration. This also improves the hostsformigration api. Firstly we were trying to list all hosts and then finding suitable storage pools for all volumes and then we were checking whether vm migration requires storage migration to that host. Now the process is updated. We are checking for only those volumes which are not in zone wide primary store. We are verifying by comparing volumes->poolid->clusterid to host clusterid. If it uses local or clusterids are different then verifying whether host has suitable storage pools for the volume of the vm to be migrated too. (cherry picked from commit 64153a43711420224655bfbe248b4b87474a1f23) - ASF Subversion and Git Services On June 20, 2014, 10:21 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22256/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 10:21 a.m.) > > > Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh > Chodapuneedi. > > > Bugs: CLOUDSTACK-6830 > https://issues.apache.org/jira/browse/CLOUDSTACK-6830 > > > Repository: cloudstack-git > > > Description > ------- > > fixed vm migration failing between different clusters if volumes are on zone > primary store. During VM migration, volumes on zone wide primary store > requiring storage migration resulting in failure of VM migration > > This also improves the hostsformigration api. Firstly we were ttrying to > list all hosts and then finding suitable storage pools for all volumes > and then we were checking for whether vm migration requires storage > migration > Now the process is reversed, We are checking for only those volumes which > are not in zone wide primary store and only verifying > that volumes->poolid->clusterid is different from host clusterid and > usesLocal then only it requires storage migration > > > Diffs > ----- > > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 4502365 > server/src/com/cloud/server/ManagementServerImpl.java dd4ce0f > > Diff: https://reviews.apache.org/r/22256/diff/ > > > Testing > ------- > > tested following scenarios on my local setup. > 1. VM migration for volumes on zone wide primary store is working fine > 2. VM migration for volumes on cluster wide primary store is working fine > 3. VM migration for volumes on local storage is working fine > > > Thanks, > > Anshul Gangwar > >
