Heya, I’m setting up a separate build (build-master-simulator) to test the build process of the simulator. At least we’ll be notified if any failures occur in the build next time. I don’t think it should be included in the regular build, it’s not something we would like to ship to end-users right?
Cheers, Hugo On 31 jul. 2014, at 06:54, Koushik Das <koushik....@citrix.com> wrote: > Simulator can be included in the default build but it needs to be tested > whether simulator plugin can coexist with actual HV plugins in the same MS > without any issues. Right now there is an issue which prevents it, refer to > https://issues.apache.org/jira/browse/CLOUDSTACK-6623. Once this is fixed it > needs to be tested again. > > Also there needs to be a consensus to include it in default profile. > > -----Original Message----- > From: Edison Su > Sent: Wednesday, 30 July 2014 11:30 PM > To: dev@cloudstack.apache.org; Koushik Das > Subject: RE: Simulator on master is not building > > +1, include simulator in the default build, exclude explicitly in the > production build. > >> -----Original Message----- >> From: Anthony Xu [mailto:xuefei...@citrix.com] >> Sent: Wednesday, July 30, 2014 10:28 AM >> To: Koushik Das; dev@cloudstack.apache.org >> Subject: RE: Simulator on master is not building >> >> We used -Dsimulator to include simulator, it is very easy for >> developers to forget it. Simulator should be built by default , we >> may use -Dnosimulator to exclude simulator. >> >> >> Anthony >> >> -----Original Message----- >> From: Koushik Das >> Sent: Wednesday, July 30, 2014 3:03 AM >> To: dev@cloudstack.apache.org >> Cc: Anthony Xu >> Subject: RE: Simulator on master is not building >> >> The simulator code should be kept up to date with any changes done in >> the core product. If there are any interface changes, necessary >> changes should be made in simulator plugin as well along with other >> hypervisor plugins. To build simulator code use refer to [1]. >> >> -Koushik >> >> [1] >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integ >> r >> ation >> >> -----Original Message----- >> From: Santhosh Edukulla [mailto:santhosh.eduku...@citrix.com] >> Sent: Wednesday, 30 July 2014 3:27 PM >> To: dev@cloudstack.apache.org >> Cc: Anthony Xu >> Subject: Simulator on master is not building >> >> I believe for every check-in we decided to run sanity tests on >> simulator atleast, currently build for simulator is failing. >> >> >> ---------------------------------------------------------------------- >> -- [ERROR] Failed to execute goal >> org.apache.maven.plugins:maven-compiler- >> plugin:2.5.1:compile (default-compile) on project >> cloud-plugin-hypervisor- >> simulator: Compilation failure: Compilation failure: >> [ERROR] >> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor >> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[230,8] >> error: 'try' without 'catch', 'finally' or resource declarations >> [ERROR] >> /home/santhosh/softwares/cs_new_master/cloudstack/plugins/hypervisor >> s/simulator/src/com/cloud/resource/AgentRoutingResource.java:[251,8] >> error: 'try' without 'catch', 'finally' or resource declarations >> >> >> Thanks! >> Santhosh
