----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24238/#review49460 -----------------------------------------------------------
tools/marvin/setup.py <https://reviews.apache.org/r/24238/#comment86531> Please tying like this to as a dependency on pom.xml, may unnecessarily lead to tight coupling with mvn logic inside of setup.py. Currently, only cloudstackAPI is the one which marvin relies upon while building cs through mvn, otherwise we can remove that dependency as well, its in plan. Any upload of marvin to external package download system will tie this dependency on pom.xml. - Santhosh Edukulla On Aug. 4, 2014, 4:08 p.m., Leo Simons wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24238/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 4:08 p.m.) > > > Review request for cloudstack and Rohit Yadav. > > > Repository: cloudstack-git > > > Description > ------- > > Commit e10f8e887571e28f31dbcf02a0beac163a901fe1 broke > mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin > Because the maven file had hard-coded 0.1.0. > > This fix removes the hard-coding completely, by having the python setup read > the version from the maven pom.xml, and the maven setup using its version. > > > Diffs > ----- > > tools/marvin/MANIFEST.in 3d373818c2096db12b61902a51f2fe39f2e0608e > tools/marvin/pom.xml 3bf70e041c6bab051d7a184ff9c3c81ea31d2054 > tools/marvin/setup.py 555d67dfc491cf5ab52d36b417a6b5842ea6ad96 > > Diff: https://reviews.apache.org/r/24238/diff/ > > > Testing > ------- > > Commands that work now for me include: > > mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin > python setup.py install > python setup.py develop > mvn -P developer -pl :cloud-marvin > > > Thanks, > > Leo Simons > >
