----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24313/#review49724 -----------------------------------------------------------
Commit 0a7af329f5386fa5fb2a2f9ebc02a2ca38bb9b17 in cloudstack's branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0a7af32 ] CLOUDSTACK-7255: Fixed marvin issue related to creating random account usernames Signed-off-by: Santhosh Edukulla <santhosh.eduku...@gmail.com> - ASF Subversion and Git Services On Aug. 6, 2014, 9:49 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24313/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 9:49 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7255 > https://issues.apache.org/jira/browse/CLOUDSTACK-7255 > > > Repository: cloudstack-git > > > Description > ------- > > Few test cases failed with "Entity already exists" while creating account > because the account name already existed in the setup. > We append random string to the username to make account names unique. Also > the account name should be less than 99 chars. > But in case where the original username becomes greater than 99 chars, > appending random string to it and trimming it back to 99 chars does not make > any difference to the original string. > > In this case the username should be trimmed first and then random string > should be appended to make the account name unique. > > > Diffs > ----- > > tools/marvin/marvin/lib/base.py 3a1f7e6 > > Diff: https://reviews.apache.org/r/24313/diff/ > > > Testing > ------- > > Yes. > > Test router internal basic zone ... SKIP: Marvin configuration has no host > credentials to check router services > > ---------------------------------------------------------------------- > Ran 1 test in 141.558s > > OK (SKIP=1) > > > Thanks, > > Gaurav Aradhye > >
