----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/#review50338 -----------------------------------------------------------
Please see my comments on dictionary.jsp: ui/dictionary.jsp <https://reviews.apache.org/r/24090/#comment88024> comma missing at the end of line ui/dictionary.jsp <https://reviews.apache.org/r/24090/#comment88023> This entry should be 'label.add.ciscoASA1000v' ui/dictionary.jsp <https://reviews.apache.org/r/24090/#comment88026> comma missing at the end of line - Mihaela Stoica On July 30, 2014, 8 a.m., Vetrivel Chinnasamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24090/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 8 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Externalized the hard-coded strings from JavaScript files to resource > bundles. Updated the dictionary.jsp file accordingly. Also got the > externalized strings translated in JA & SC. > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties a0205e1 > client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 > client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc > tools/ngui/static/js/app/storage/storage.js af36167 > ui/dictionary.jsp 10aeaf9 > ui/lib/flot/jquery.flot.pie.js b46c03c > ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a > ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 > ui/scripts/accounts.js 2ebfe82 > ui/scripts/autoscaler.js c8963fd > ui/scripts/configuration.js 895f8e8 > ui/scripts/domains.js 488382e > ui/scripts/events.js 2731cb6 > ui/scripts/instances.js 93a40fc > ui/scripts/lbStickyPolicy.js 16995f6 > ui/scripts/network.js b3a003d > ui/scripts/projects.js 53b7964 > ui/scripts/regions.js 368c1bf > ui/scripts/sharedFunctions.js e8c4fcb > ui/scripts/storage.js f4ab6e1 > ui/scripts/system.js 3b53df6 > ui/scripts/templates.js 3e048cc > ui/scripts/ui-custom/autoscaler.js 0aa6c77 > ui/scripts/ui-custom/healthCheck.js 4e10f1c > ui/scripts/ui-custom/physicalResources.js ac379b4 > ui/scripts/ui-custom/regions.js 986e009 > ui/scripts/ui-custom/zoneWizard.js f3a1aae > ui/scripts/ui/dialog.js 0fddcf7 > ui/scripts/ui/widgets/listView.js 22182c1 > ui/scripts/ui/widgets/multiEdit.js 47e5f43 > ui/scripts/vpc.js 83c5b83 > ui/scripts/zoneWizard.js 0a84bdb > > Diff: https://reviews.apache.org/r/24090/diff/ > > > Testing > ------- > > Tested by replacing the modified javascript , dictionary.jsp and properties > files. > > > Thanks, > > Vetrivel Chinnasamy > >
