> On Aug. 22, 2014, 4:39 a.m., Rajani Karuturi wrote: > > client/tomcatconf/server-nonssl.xml.in, line 29 > > <https://reviews.apache.org/r/24936/diff/1/?file=666191#file666191line29> > > > > Aren't we loosing the jmx support on tomcat6 by commenting this?
As of my understanding it is to manage tomcat server(MBeans related to tomcat server) via JMX but does not eleminate JMX completely. That is why I raised the same in the community for confirmation. http://tomcat.apache.org/tomcat-6.0-doc/config/listeners.html#Server_Lifecycle_Listener_-_org.apache.catalina.mbeans.ServerLifecycleListener > On Aug. 22, 2014, 4:39 a.m., Rajani Karuturi wrote: > > client/tomcatconf/server-nonssl.xml.in, line 143 > > <https://reviews.apache.org/r/24936/diff/1/?file=666191#file666191line143> > > > > Was there any performance impact on tomcat6 due to this change? Dont we > > need separate files for tomcat6 and 7? Did not see any response delay impact. Probably my server is not heavily loaded so could not differentiate the response delays.. - Damodar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24936/#review51250 ----------------------------------------------------------- On Aug. 21, 2014, 4:15 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24936/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 4:15 p.m.) > > > Review request for cloudstack, Rayees Namathponnan and Hugo Trippaers. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7106 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7106 > > > Repository: cloudstack-git > > > Description > ------- > > RPM Build was failing on RHEL7 due to the packages changed in RHEL7. > Refactored the cloud.spec to make it specific to OS builds. > > > Diffs > ----- > > client/tomcatconf/server-nonssl.xml.in 847197c > client/tomcatconf/server-ssl.xml.in 37bc53d > packaging/centos63/cloud-management.rc 2f04793 > packaging/centos63/cloud.spec 7565f95 > packaging/centos63/default/macros.spec PRE-CREATION > packaging/centos63/default/tomcat.sh PRE-CREATION > packaging/centos63/package.sh 07f95fc > packaging/centos63/rhel7/cloud-management.service PRE-CREATION > packaging/centos63/rhel7/macros.spec PRE-CREATION > packaging/centos63/rhel7/tomcat.sh PRE-CREATION > python/lib/cloudutils/serviceConfigServer.py 2c19d7e > > Diff: https://reviews.apache.org/r/24936/diff/ > > > Testing > ------- > > Tested on RHEL7 and Centos 6.3 > > > Thanks, > > Damodar Reddy Talakanti > >
