-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25023/
-----------------------------------------------------------

(Updated Aug. 25, 2014, 7:55 p.m.)


Review request for cloudstack, Marcus Sorensen, Sebastien Goasguen, and Wido 
den Hollander.


Changes
-------

This should make all the urls accessible with and without trailing slash.

Testing done:

without trailing slash:
[root@jenkins ~]# for i in "local-hostname" "local-ipv4" "vm-id" "instance-id" 
; do curl -s -I 10.30.81.1/latest/meta-data/$i | grep HTTP; done
HTTP/1.1 200 OK
HTTP/1.1 200 OK
HTTP/1.1 200 OK
HTTP/1.1 200 OK


with trailing slash:
[root@jenkins ~]# for i in "local-hostname" "local-ipv4" "vm-id" "instance-id" 
; do curl -s -I 10.30.81.1/latest/meta-data/$i/ | grep HTTP; done
HTTP/1.1 200 OK
HTTP/1.1 200 OK
HTTP/1.1 200 OK
HTTP/1.1 200 OK


Bugs: CLOUDSTACK-7405
    https://issues.apache.org/jira/browse/CLOUDSTACK-7405


Repository: cloudstack-git


Description
-------

As per https://issues.apache.org/jira/browse/CLOUDSTACK-7405 cloud-init expects 
to be able to get meta-data directory without using a trailing slash.

Ultimately this should be fixed in cloud-init, but it's an unintrusive fix in 
cloudstack


Diffs (updated)
-----

  systemvm/patches/debian/config/opt/cloud/bin/vmdata.py f508032 

Diff: https://reviews.apache.org/r/25023/diff/


Testing
-------

tested with curl that both new and old url works

[root@jenkins ~]# curl -I -s 10.30.81.1/latest/meta-data/vm-id | grep HTTP
HTTP/1.1 200 OK
[root@jenkins ~]# curl -I -s 10.30.81.1/latest/meta-data | grep HTTP
HTTP/1.1 200 OK


Thanks,

Erik Weber

Reply via email to