Hey Rohit, It does break CS startup, otherwise i would not have reverted it. Spring does not tolerate empty xml files.
Cheers, Hugo On 2 sep. 2014, at 10:19, Rohit Yadav <rohityada...@gmail.com> wrote: > Hi Hugo, > > On Tue, Sep 2, 2014 at 10:09 AM, <h...@apache.org> wrote: > Revert "server: Add event bus bean as commented xml in META-INF core" > > Breaks CloudStack startup. You're better off putting this on the wiki > > Alright will do, but this is just a file in which the bean is commented so it > does not break CloudStack startup. > > Regards. > > > This reverts commit c730bc3491f8b684c5ae51e0bff54cf7577cc246. > > > Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo > Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/f636611c > Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/f636611c > Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/f636611c > > Branch: refs/heads/master > Commit: f636611caca7dfe1f6b7a2da6d0da530ffb6e502 > Parents: 3d04b52 > Author: Hugo Trippaers <htrippa...@schubergphilis.com> > Authored: Tue Sep 2 09:58:25 2014 +0200 > Committer: Hugo Trippaers <htrippa...@schubergphilis.com> > Committed: Tue Sep 2 10:09:04 2014 +0200 > > ---------------------------------------------------------------------- > .../core/spring-event-bus-context.xml | 38 -------------------- > 1 file changed, 38 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/cloudstack/blob/f636611c/server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml > ---------------------------------------------------------------------- > diff --git > a/server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml > b/server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml > deleted file mode 100644 > index 3e1a8ed..0000000 > --- a/server/resources/META-INF/cloudstack/core/spring-event-bus-context.xml > +++ /dev/null > @@ -1,38 +0,0 @@ > -<!-- > - Licensed to the Apache Software Foundation (ASF) under one > - or more contributor license agreements. See the NOTICE file > - distributed with this work for additional information > - regarding copyright ownership. The ASF licenses this file > - to you under the Apache License, Version 2.0 (the > - "License"); you may not use this file except in compliance > - with the License. You may obtain a copy of the License at > - > - http://www.apache.org/licenses/LICENSE-2.0 > - > - Unless required by applicable law or agreed to in writing, > - software distributed under the License is distributed on an > - "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > - KIND, either express or implied. See the License for the > - specific language governing permissions and limitations > - under the License. > ---> > -<!-- > -<beans xmlns="http://www.springframework.org/schema/beans"; > -xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > -xmlns:context="http://www.springframework.org/schema/context"; > -xmlns:aop="http://www.springframework.org/schema/aop"; > -xsi:schemaLocation="http://www.springframework.org/schema/beans > -http://www.springframework.org/schema/beans/spring-beans-3.0.xsd > -http://www.springframework.org/schema/aop > http://www.springframework.org/schema/aop/spring-aop-3.0.xsd > -http://www.springframework.org/schema/context > -http://www.springframework.org/schema/context/spring-context-3.0.xsd";> > - <bean id="eventNotificationBus" > class="org.apache.cloudstack.mom.rabbitmq.RabbitMQEventBus"> > - <property name="name" value="eventNotificationBus"/> > - <property name="server" value="127.0.0.1"/> > - <property name="port" value="5672"/> > - <property name="username" value="guest"/> > - <property name="password" value="guest"/> > - <property name="exchange" value="cloudstack-events"/> > - </bean> > -</beans> > ---> > >
