On Sep 2, 2014, at 11:56 AM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote:
> > On 02-Sep-2014, at 5:40 pm, Rajani Karuturi <raj...@apache.org> wrote: >> The right way to do this is to do commit to commit migrations and use some >> db versioning tools like liquibase or flywaydb which will execute the new >> change sets. We discussed this before and IIRC, someone started working on >> it. > > This is not a proposal thread to introduce new tools and I would certainly > avoid the “right way to do things” as I’m a fan of iterative development. > > I’m interested in a concrete solution to the concrete issue I raised. Here’s > how I will do it: > > - Fix the issue on 4.3.1, cherry pick and get rid of the 4.3.0 to 4.4.0 > upgrade path > - Put the db changes in upgrade path from 4.3.0 to 4.3.1, on 4.3 branch > - Add an upgrade path from 4.3.1 to 4.4.1 on 4.4 branch which counts for the > above change > - On 4.4 branch, in the upgrade (db upgrader) map there won’t be an upgrade > path from 4.3.1 for any class except for the map entry where version is 4.3.1 > - Users who upgrade to 4.3.1 can upgrade only to 4.4.1 (they don’t have a > choice) and the upgrade path will exist only in 4.4.1 and later releases > > I think if I do the above, no one will have any issue. I’m sharing them to > run by you all in case you find any issue? > Or: #1: we don't release 4.3.1 The main reason that I wanted to do 4.3.1 is to start providing some sort of LTS…but maybe our LTS strategy is to move towards rolling upgrades. >> >> >> On Tue, Sep 2, 2014 at 20:58 PM, Rohit Yadav <rohit.ya...@shapeblue.com> >> wrote: >> >> >> On 02-Sep-2014, at 5:07 pm, Francois Gaudreault <fgaudrea...@cloudops.com >> <javascript:;>> wrote: >>> I see. Well, I think we were impacted by that too, and we made the >> decision to move on 4.4.1-snap (even if it's technically less stable?) and >> then upgrade to 4.4.1 GA (next week?) >>> >>> I personally don't think pulling back DB changes in lower releases is a >> good idea :S >>> >>> But that's only my opinion :) >> >> I raised a concrete issue regarding 4.3.1/4.4.1 release and I would like to >> stick to that only. I understand there are too many numbers, versions and >> branches to follow, so please if you can try to understand the issue; >> >> This issue — https://issues.apache.org/jira/browse/CLOUDSTACK-6756 requires >> that there are some extra columns in the database to do book keeping when >> delete ips so you don’t actually delete db/table rows. >> >> The issue above is fixed in an upgrade path from 4.3.0 to 4.4.0: >> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=setup/db/db/schema-430to440.sql;h=226260804523c79e3ce3cfa3c407b5ac698d749c;hp=3b525c41a1befd94c5ffc324c357b566606a97d0;hb=ce6a53e;hpb=d0f806b3a486c58b033083fc57f39dd686e31750 >> >> But, we already have 4.4.0 release and db upgrade paths are always in the >> next release versions. >> >> So, there is no upgrade path from 4.3.1 to 4.4.0; as 4.3.1 version does not >> care about 4.4.0 schema changes. There is only an upgrade path from 4.3.0 >> to 4.3.1. So, the limitation is that people won’t be able to upgrade from >> 4.3.1 to 4.4.0, because 4.4.0 is already released. >> >> If we release 4.4.1 before 4.3.1, we’ll have the same issue. So, we can put >> the fix from the JIRA issue on 4.3 branch so the issue is fixed for 4.3.1. >> The fix will be in the 4.3.0 to 4.3.1 upgrade path. And, if we release >> 4.4.1 after 4.3.1, we can fix the upgrade path from 4.3.1 to 4.4.1 on 4.4 >> branch such that >> >> The abstract issue is — we’ll have such issue in future, how do we fix it. >> I suggested — we make a separate tool that does (rolling) upgrades. >> >> Regards, >> Rohit Yadav >> Software Architect, ShapeBlue >> M. +41 779015219 | rohit.ya...@shapeblue.com <javascript:;> >> Blog: bhaisaab.org | Twitter: @_bhaisaab >> >> >> >> Find out more about ShapeBlue and our range of CloudStack related services >> >> IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build// >>> >> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> >> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> >> CloudStack Infrastructure Support< >> http://shapeblue.com/cloudstack-infrastructure-support/> >> CloudStack Bootcamp Training Courses< >> http://shapeblue.com/cloudstack-training/> >> >> This email and any attachments to it may be confidential and are intended >> solely for the use of the individual to whom it is addressed. Any views or >> opinions expressed are solely those of the author and do not necessarily >> represent those of Shape Blue Ltd or related companies. If you are not the >> intended recipient of this email, you must neither take any action based >> upon its contents, nor copy or show it to anyone. Please contact the sender >> if you believe you have received this email in error. Shape Blue Ltd is a >> company incorporated in England & Wales. ShapeBlue Services India LLP is a >> company incorporated in India and is operated under license from Shape Blue >> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil >> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is >> a company registered by The Republic of South Africa and is traded under >> license from Shape Blue Ltd. ShapeBlue is a registered trademark. >> >> >> >> -- >> ~Rajani >> Sent from Windows Phone > > Regards, > Rohit Yadav > Software Architect, ShapeBlue > M. +41 779015219 | rohit.ya...@shapeblue.com > Blog: bhaisaab.org | Twitter: @_bhaisaab > > > > Find out more about ShapeBlue and our range of CloudStack related services > > IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> > CloudStack Infrastructure > Support<http://shapeblue.com/cloudstack-infrastructure-support/> > CloudStack Bootcamp Training > Courses<http://shapeblue.com/cloudstack-training/> > > This email and any attachments to it may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any views or > opinions expressed are solely those of the author and do not necessarily > represent those of Shape Blue Ltd or related companies. If you are not the > intended recipient of this email, you must neither take any action based upon > its contents, nor copy or show it to anyone. Please contact the sender if you > believe you have received this email in error. Shape Blue Ltd is a company > incorporated in England & Wales. ShapeBlue Services India LLP is a company > incorporated in India and is operated under license from Shape Blue Ltd. > Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is > operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company > registered by The Republic of South Africa and is traded under license from > Shape Blue Ltd. ShapeBlue is a registered trademark.
