----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25258/#review52061 -----------------------------------------------------------
Ship it! Committed with SHA 24dd6cee78ec779498b532d5dbb5015490642129 Thanks for changing the test! :) - Mike Tutkowski On Sept. 2, 2014, 11:48 a.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25258/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 11:48 a.m.) > > > Review request for cloudstack and Mike Tutkowski. > > > Bugs: CLOUDSTACK-7467 > https://issues.apache.org/jira/browse/CLOUDSTACK-7467 > > > Repository: cloudstack-git > > > Description > ------- > > Previously if you had a volume using a non customisable disk offering, and > attempted to resize it passing in the same disk offering id, the command would > be accepted, but it would actually be resized to its current size (i.e. the > provided size parameter was ignored). This is what the test used to check. > > Commit de6a3112b6b80952d1598acaa112ac50a3ef9d32 modified the logic to check if > the provided diskofferingid was the same as the current one, and if so treat > it > as if it hadn't been provided - this means the resize command now fails, which > is probably the more sensible thing to do (rather than giving the impression > it > will be resized but actually not doing so). > > This change therefore modifies the test logic to match. > > > Diffs > ----- > > test/integration/smoke/test_volumes.py e2e0d76 > > Diff: https://reviews.apache.org/r/25258/diff/ > > > Testing > ------- > > Test passed running against current build > > > Thanks, > > Alex Brett > >
