> On Sept. 8, 2014, 9:27 a.m., Rohit Yadav wrote: > > server/src/com/cloud/server/ManagementServerImpl.java, lines 1160-1161 > > <https://reviews.apache.org/r/25430/diff/1/?file=682473#file682473line1160> > > > > Why not fix VirtualMachineProfileImpl constructor where we're passing > > the offering? > > > > VirtualMachineProfile vmProfile = new VirtualMachineProfileImpl(vm, > > null, _offeringDao.findById(vm.getId(), vm.getServiceOfferingId()), null, > > null);
it is a typo, fixed this. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52575 ----------------------------------------------------------- On Sept. 8, 2014, 9:16 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25430/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 9:16 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-6099 > https://issues.apache.org/jira/browse/CLOUDSTACK-6099 > > > Repository: cloudstack-git > > > Description > ------- > > live migration is failing for vm deployed using dynaic compute offerings with > NPE > https://issues.apache.org/jira/browse/CLOUDSTACK-6099 > > > Diffs > ----- > > api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 > engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java > a1e2528 > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 8edef77 > server/src/com/cloud/server/ManagementServerImpl.java 697d1c4 > > Diff: https://reviews.apache.org/r/25430/diff/ > > > Testing > ------- > > Tested live migration on master using xenserver. > > > Thanks, > > bharat kumar > >
