> On Sept. 16, 2014, 11:40 a.m., SrikanteswaraRao Talluri wrote: > > test/integration/component/test_brocade_vcs.py, line 130 > > <https://reviews.apache.org/r/25642/diff/1/?file=689311#file689311line130> > > > > need an assert for password too??
I don't think that's mandatory. Sometimes password can be null as it can be for sql db. That's why didn't add assert for it. Person running tests can make sure he is adding correct password. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25642/#review53478 ----------------------------------------------------------- On Sept. 16, 2014, 11:32 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25642/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 11:32 a.m.) > > > Review request for cloudstack, Ritu Sabharwal, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7547 > https://issues.apache.org/jira/browse/CLOUDSTACK-7547 > > > Repository: cloudstack-git > > > Description > ------- > > Brocade device data was hard coded. > > 1) Made changes so that it can be read from the config file. (Config > tranlated to the config file we provide to jenkins, not test_data.py file, > because dynamic data should always be placed in config, not test_data.py) > 2) Skipped the test case if the data is not present in config file. > 3) Removed * from imports and made appropriate changes. > > Following data is supposed to be present in config file, if not present, test > case will be skipped. > > "brocadeDeviceData": > { > "ipaddress": "X.X.X.X", > "username": "userxxx", > "password": "passxxx" > } > > > Diffs > ----- > > test/integration/component/test_brocade_vcs.py a5eff53 > > Diff: https://reviews.apache.org/r/25642/diff/ > > > Testing > ------- > > Yes. > > Tested all the scenarios of valid and invalid data. > Skipping of test case was proper. > > When all the data was present, test case moved forward to adding the brocade > device but test case still failed because the details I put in config file > were not valid (I don't have brocade device details). > > > Thanks, > > Gaurav Aradhye > >
