----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review53503 -----------------------------------------------------------
I still can see vmware.reserve.mem in the global settings, if we want to expose this to cluster level settings let's get opinion from VMWare maintainers such as Koushik. plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java <https://reviews.apache.org/r/20518/#comment93195> Avoid hardcoding string "vmware.reserve.mem", using Config class to get value plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java <https://reviews.apache.org/r/20518/#comment93196> avoid hard coding here too plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java <https://reviews.apache.org/r/20518/#comment93197> Are we using _reserveCpu and _reserveMem in any other place? server/src/com/cloud/configuration/Config.java <https://reviews.apache.org/r/20518/#comment93198> This removes vmware.reserve.mem and vmware.reserve.cpu from global settings, won't this break backward compatibility. - Rohit Yadav On April 21, 2014, 9:42 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20518/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 9:42 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-6465 > https://issues.apache.org/jira/browse/CLOUDSTACK-6465 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings > > > Diffs > ----- > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 77c45b2 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 67d3963 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 945773e > server/src/com/cloud/configuration/Config.java e45291d > > Diff: https://reviews.apache.org/r/20518/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
