----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26008/#review54795 -----------------------------------------------------------
Here are few comments: test/integration/component/test_remotevpn_vpc.py <https://reviews.apache.org/r/26008/#comment95065> try to use validateList() from utils.py test/integration/component/test_remotevpn_vpc.py <https://reviews.apache.org/r/26008/#comment95064> Please use 'self.__class__' instead of directly using the class name which improves maintainability of the code. Just in case, if you want to change the class name in future, you don't have to change at all the places. - SrikanteswaraRao Talluri On Sept. 25, 2014, 12:15 a.m., Chandan Purushothama wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26008/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 12:15 a.m.) > > > Review request for cloudstack, sangeetha hariharan, sanjeev n, Santhosh > Edukulla, and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7627 > https://issues.apache.org/jira/browse/CLOUDSTACK-7627 > > > Repository: cloudstack-git > > > Description > ------- > > Test Suite for Testing Remote Access VPN on VPC. > > I successfully automated the following components: > > 1.VPN Client Installation on Linux > 2.Component that efficiently verifies Remote VPN Access between client and > the Server. > 3.Developed a component that automates VPN Client Configuration and services. > 4.Test Cases of the Feature > 5.Tested the Code multiple times on XenServer. > 6.Tested the Code multiple times on VMWare (To test Skipping of Test Cases) > > > Diffs > ----- > > test/integration/component/test_remotevpn_vpc.py PRE-CREATION > tools/marvin/marvin/config/test_data.py bebcab9 > > Diff: https://reviews.apache.org/r/26008/diff/ > > > Testing > ------- > > Testing Done on Two Configurations: XenServer and VMWare > > XenServer Test Results: > > Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: > test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS === > ok > Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser > | Status : SUCCESS === > ok > Test case 03 : Add a Different VPN User and Test Access with already existing > VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS > === > ok > Test case 04 : Add a Previously Removed VPN User from the VPC and Test the > VPN Connectivity ... === TestName: > test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS === > ok > Test case 05 : Disable the VPN Service on the VPC ... === TestName: > test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS === > ok > Test case 06 : Enabled Previously Dsiabled VPN Access to VPC. ... === > TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : > SUCCESS === > ok > Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 > Configuration parameter ... === TestName: > test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 7 tests in 851.687s > > OK > > > VMWare Test Results: > > === TestName: None | Status : EXCEPTION === > SKIP: Only XenServer VPNClient Template is ready currently. KVM,VMWare or > Hyper-V VPN Client Templates are not ready. Skipping the test suite for those > configurations > -------------------- >> begin captured stdout << --------------------- > === TestName: None | Status : EXCEPTION === > > > --------------------- >> end captured stdout << ---------------------- > -------------------- >> begin captured logging << -------------------- > CSLog: DEBUG: Obtain the Admin's API Client > CSLog: DEBUG: Get the dictionary information that will be used during CCP > tests, from test_data.py present on the Client > CSLog: DEBUG: Payload: {'apiKey': > u'fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ', > 'command': 'listDomains', 'signature': '5BHLOjDELImWRpvI/16LQ/TrLRM=', > 'response': 'json'} > CSLog: DEBUG: ========Sending GET Cmd : listDomains======= > requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection > (1): 10.220.135.90 > requests.packages.urllib3.connectionpool: DEBUG: "GET > /client/api?apiKey=fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ&command=listDomains&response=json&signature=5BHLOjDELImWRpvI%2F16LQ%2FTrLRM%3D > HTTP/1.1" 200 159 > CSLog: DEBUG: Response : [{path : u'ROOT', haschild : False, id : > u'42ebae70-4375-11e4-86a1-66733ba24ed8', name : u'ROOT', level : 0}] > CSLog: DEBUG: Payload: {'apiKey': > u'fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ', > 'name': u'XenRT-Zone-0', 'command': 'listZones', 'signature': > 'MH3voxNCEMIMA3deggb/EVxAog8=', 'response': 'json'} > CSLog: DEBUG: ========Sending GET Cmd : listZones======= > requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection > (1): 10.220.135.90 > requests.packages.urllib3.connectionpool: DEBUG: "GET > /client/api?response=json&apiKey=fGs23pVVge8K-HxeQCo3WBCria7hJs5JZW_j7cKnX1mMpbBKH8JwNCxcWHxBgA-slwW0d1YJHJKbCX_Doc3-GQ&command=listZones&name=XenRT-Zone-0&signature=MH3voxNCEMIMA3deggb%2FEVxAog8%3D > HTTP/1.1" 200 416 > CSLog: DEBUG: Response : [{localstorageenabled : False, name : > u'XenRT-Zone-0', guestcidraddress : u'192.168.200.0/24', tags : [], zonetoken > : u'd8f55583-777e-3f86-9a97-8b35a24bd558', dns1 : u'10.220.247.5', > securitygroupsenabled : False, allocationstate : u'Enabled', internaldns1 : > u'10.220.112.11', dhcpprovider : u'VirtualRouter', networktype : u'Advanced', > id : u'60a2c7cc-0f4f-4114-978a-f67b0aa9d25c'}] > CSLog: CRITICAL: EXCEPTION: None: ['Traceback (most recent call last):\n', ' > File "/usr/lib/python2.7/site-packages/nose/suite.py", line 209, in run\n > self.setUp()\n', ' File "/usr/lib/python2.7/site-packages/nose/suite.py", > line 292, in setUp\n self.setupContext(ancestor)\n', ' File > "/usr/lib/python2.7/site-packages/nose/suite.py", line 315, in setupContext\n > try_run(context, names)\n', ' File > "/usr/lib/python2.7/site-packages/nose/util.py", line 470, in try_run\n > return func()\n', ' File "/home/Chandan/test_remotevpn_vpc.py", line 88, in > setUpClass\n raise unittest.SkipTest("Only XenServer VPNClient Template is > ready currently. KVM,VMWare or Hyper-V VPN Client Templates are not ready. > Skipping the test suite for those configurations")\n', 'SkipTest: Only > XenServer VPNClient Template is ready currently. KVM,VMWare or Hyper-V VPN > Client Templates are not ready. Skipping the test suite for those > configurations\n'] > --------------------- >> end captured logging << --------------------- > > ---------------------------------------------------------------------- > Ran 0 tests in 0.164s > > OK (SKIP=1) > > > Thanks, > > Chandan Purushothama > >
