-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26224/
-----------------------------------------------------------
Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7649
https://issues.apache.org/jira/browse/CLOUDSTACK-7649
Repository: cloudstack-git
Description
-------
The test case tries to SSH to VM using secondary IP after destroying and
recovering it.
However, seconday IP information is not retained in the VM once it is destroyed
and SSH fails.
The step should be removed and only step to check the existence of LB rules
poiting to secondary IP should be retained.
Once the secondary IP is manually configured on VM again, SSH will start
working as before.
Changes:
1. Removed SSH step after reovering VM
2. Fixed all pep8 issues
Diffs
-----
test/integration/component/test_lb_secondary_ip.py b1cb78a
Diff: https://reviews.apache.org/r/26224/diff/
Testing
-------
Yes.
Log:
Create LB rule for primary IP ... SKIP: Skip
Create LB rule for secondary IP ... SKIP: Skip
Create LB rule for primary and secondary IP ... SKIP: Skip
Create LB rule for primary and secondary IPs of multiple VMs ... SKIP: Skip
Try to assign LB rule to secondary IP by giving wrong vm id ... SKIP: Skip
Try to assign LB rule to secondary IP by giving wrong ip ... SKIP: Skip
Try to assign secondary IP to lb rule which is already assigned to another ...
SKIP: Failing-WIP
Try to remove secondary IP with load balancer rule configured for it ... SKIP:
Skip
SSH to VM using LB rule assigned to secondary IP of VM ... SKIP: Skip
SSH to VM using LB rule assigned to primary and secondary IP of VM ... SKIP:
Failing-WIP
SSH to VM after deleting LB rule ... SKIP: Skip
ssh to vm after removing secondary ip from load balancer rule ... SKIP: Skip
ssh to vm after removing secondary ip from load balancer rule ... SKIP: Skip
ssh to vm after removing secondary ip from load balancer rule ... SKIP: Skip
Verify LB rules after destroying and recovering VM ... === TestName:
test_20_destroy_recover_vm | Status : SUCCESS ===
ok
Verify LB rule functioning with different algorithm ... SKIP: Skip
List load balancer instances by passing lbvmips flag True ... SKIP: Skip
List load balancer instances by passing lbvmips flag False ... SKIP: Skip
Verify LB rules after restarting router VM ... SKIP: Skip
Verfy LB rules after restarting the network with cleanup flag set to True ...
SKIP: Skip
Verfy LB rules after restarting the network with cleanup flag set to False ...
SKIP: Skip
Verify LB rule functioning to secondary IP after network GC ... SKIP: Skip
----------------------------------------------------------------------
Ran 22 tests in 303.021s
OK (SKIP=21)
Thanks,
Gaurav Aradhye
