> On Oct. 8, 2014, 5:07 p.m., Frank Zhang wrote: > > Ship It!
Unfortunately what's actually been pushed in https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=f96c65416a2802bcf2a1f8d5a5070ffe6a29111f is missing a rather crucial change - in package.sh while it now takes the simulator argument, it doesn't actually pass it on to the rpmbuild command, i.e. this part of the diff has been missed: ``` - (cd $RPMDIR; rpmbuild --define "_topdir $RPMDIR" "${DEFVER}" "${DEFREL}" ${DEFPRE+"${DEFPRE}"} ${DEFOSSNOSS+"$DEFOSSNOSS"} "${DOS}" -bb SPECS/cloud.spec) + (cd $RPMDIR; rpmbuild --define "_topdir $RPMDIR" "${DEFVER}" "${DEFREL}" ${DEFPRE+"${DEFPRE}"} ${DEFOSSNOSS+"$DEFOSSNOSS"} ${DEFSIM+"$DEFSIM"} "${DOS}" -bb SPECS/cloud.spec) ``` - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25266/#review55820 ----------------------------------------------------------- On Sept. 19, 2014, 7:17 p.m., Rayees Namathponnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25266/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 7:17 p.m.) > > > Review request for cloudstack, Frank Zhang and Hugo Trippaers. > > > Bugs: CLOUDSTACK-7469 > https://issues.apache.org/jira/browse/CLOUDSTACK-7469 > > > Repository: cloudstack-git > > > Description > ------- > > Currently there is no option to build rpm with simulator, as part this patch > modified package.sh file to accept simulator > > also updated cloud.spec file to build both oss and nooss simulator buids > > > To build noredist and simulator, you need to use below package command > ./package.sh --pack noredist --s simulator > > default package with simulato, need to call ./package.sh > > > Diffs > ----- > > packaging/centos63/cloud.spec 7306d1f > packaging/centos63/package.sh 6a2d168 > > Diff: https://reviews.apache.org/r/25266/diff/ > > > Testing > ------- > > Yes > > > File Attachments > ---------------- > > 0001-Simulator-build-support-for-RPM-builds.patch > > https://reviews.apache.org/media/uploaded/files/2014/09/19/2537284e-f1de-419a-b5b6-66b8ddfcac84__0001-Simulator-build-support-for-RPM-builds.patch > > > Thanks, > > Rayees Namathponnan > >
