> On Oct. 17, 2014, 5:41 p.m., Nitin Mehta wrote: > > tools/appliance/build.sh, line 253 > > <https://reviews.apache.org/r/26871/diff/1/?file=724288#file724288line253> > > > > Why should version be optional at all ? > > 1. I think it should be mandatory. > > 2. I would like you to do a more harder check on version making sure it > > is in correct format as per expectations say it should be > 1.0 and less > > than say 10.0 < it should be an integer etc. > > Harikrishna Patnala wrote: > Why it should be mandatory? if it has a default value. > This value represents, in which version the template is released and is > used to check if router upgrade is needed. > > I think the parameter is made optional, so that at any point of time > during template build, we can make the template refer to that particular > version if we want to. > > The current template build jobs are based on the default value. It is > good to have harder check, I'll create a ticket for that.
The default value is not right. Once we move to 4.5/4.6 and say systemvm template changes the default should be accordingly different so I dont think there should be a default value. It would be great if you could make the stricter check as well right now, but I am fine either ways. Please do put the ticket and target for 4.5. Thanks. - Nitin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26871/#review57173 ----------------------------------------------------------- On Oct. 17, 2014, 5:30 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26871/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 5:30 p.m.) > > > Review request for cloudstack, Kishan Kavala and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7748 > https://issues.apache.org/jira/browse/CLOUDSTACK-7748 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-7748: Cloudstack version number is missing in system vm template. > /etc/cloudstack-release in system vm does not have version number which > leads in vm deployment failure while checking router version > > > During the system vm build, arguments can be passed to build.sh script > where 'version' argument is one of the optional arguments. The bug is even if > version argument is not passed defalut value(CLOUDSTACK_RELEASE=4.4.0) is > overridden by the null value (since argument is not passed). > > > Diffs > ----- > > tools/appliance/build.sh 8bf78b1 > > Diff: https://reviews.apache.org/r/26871/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
