> On Oct. 28, 2014, 9:34 p.m., Brian Federle wrote:
> > Gabor, I am getting an error from this on the add VPC dialog, for the new
> > validation present on the network domain field:
> >
> > networkdomain: {
> > docID: 'helpVPCDomain',
> > - label:
> > 'label.DNS.domain.for.guest.networks'
> > + label:
> > 'label.DNS.domain.for.guest.networks',
> > + validation: {
> > + ipv4: true
> > + }
> > },
> >
> > Uncaught TypeError: Cannot read property 'call' of undefined
> >
> >
> > -- I think this might be because your other patch for CLOUDSTACK-7765
> > wasn't applied yet (due to conflicts), but can you confirm if you are able
> > to reproduce this issue or not, once fixing the other patch?
Brian, thanks for reviewing. Yes, this is caused by the missing ipv4cidr
validator that is defined in CLOUDSTACK-7765. Once that has been committed,
this change would work as expected.
Could you please recheck this after 7765 has been applied? (Please let me fix
7765 first.)
- Gabor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27300/#review58881
-----------------------------------------------------------
On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27300/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 7:16 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-7766
> https://issues.apache.org/jira/browse/CLOUDSTACK-7766
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Field Validations for the Start Port, End Port and CIDR fields
> Ingress and Egress rules.
>
> NOTE: In order for this patch to work it needs [CLOUDSTACK-7765: Field
> Validations Missing for VPC IP Address] applied before.
>
>
> Diffs
> -----
>
> ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3
> ui/scripts/ui/widgets/multiEdit.js c4de8cecbe296607dac90a2c1eb6d362e33b1033
>
> Diff: https://reviews.apache.org/r/27300/diff/
>
>
> Testing
> -------
>
> Tested validation on these fields
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>
