----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27571/#review59937 -----------------------------------------------------------
Ship it! 2cd4ad201adbee3ad75dd57d8196b633cdd0494b 4.5 fce9f9639988b4ef69f0312e0d13a0169ca7e5ed master - SrikanteswaraRao Talluri On Nov. 4, 2014, 12:54 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27571/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 12:54 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7800 > https://issues.apache.org/jira/browse/CLOUDSTACK-7800 > > > Repository: cloudstack-git > > > Description > ------- > > Only the unplug operation fails on VMware if vmware-tools are not present. > Plug operation succeeds anyway. > Included this change in the test code. > > > Diffs > ----- > > test/integration/smoke/test_nic.py f130bbe > > Diff: https://reviews.apache.org/r/27571/diff/ > > > Testing > ------- > > Tested both on KVM and VMware. > > Vmware Log: > Test to add and update added nic to a virtual machine ... === TestName: > test_01_nic | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 1 test in 263.081s > > OK > > > Thanks, > > Gaurav Aradhye > >