Wido,
If i get your note, then shall i remove the mentioned if else logic only to one
liner as below?
newDisk = destPool.createPhysicalDisk(name, Storage.ProvisioningType.THIN,
disk.getVirtualSize());
Regards,
Santhosh
________________________________________
From: Wido den Hollander [w...@widodh.nl]
Sent: Monday, November 03, 2014 5:27 AM
To: Santhosh Edukulla; dev@cloudstack.apache.org
Cc: shadow...@gmail.com
Subject: Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]
On 11/03/2014 10:05 AM, Santhosh Edukulla wrote:
> Team,
>
> Either of the paths are doing the same thing for below if else, please check.
> This is observed under master.
>
I think that is a weird merge thing somewhere. I don't see any reason
why this if statement is there.
Wido
> if (srcPool.getType() != StoragePoolType.RBD) {
> newDisk = destPool.createPhysicalDisk(name,
> Storage.ProvisioningType.THIN, disk.getVirtualSize());
> } else {
> newDisk = destPool.createPhysicalDisk(name,
> Storage.ProvisioningType.THIN, disk.getVirtualSize());
> }
>
> Santhosh
>
