-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27979/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 1:44 p.m.)
Review request for cloudstack, Kishan Kavala, Rohit Yadav, Simon Fiddaman,
Stephen Hoogendijk, and Wei Zhou.
Changes
-------
1. Maintained latest changed in master.
2. Removed constant declaration duplication, and decreased the limit (as
suggested in feedback) to 1.
Bugs: CLOUDSTACK-7903
https://issues.apache.org/jira/browse/CLOUDSTACK-7903
Repository: cloudstack-git
Description (updated)
-------
When you want to build 95-percentile billing model for the network traffic
usage, it is good to have 5-minutes (or 1-minute) usage samples instead of 10
(which is minimum allowed in ACS at the moment). Let admin to control it.
This change decreases the lower limit for USAGE_AGGREGATION_RANGE_MIN
parameter, making it minimum possible positive integer. It is also removes
declaration of the same constant in 3 places.
Will be happy if patch can be:
- cherry-picked to the 4.4 and 4.5 branches
- included to the 4.4.2 tag.
Diffs (updated)
-----
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
23ddfb1
server/src/com/cloud/server/StatsCollector.java 1fcaa62
usage/src/com/cloud/usage/UsageManagerImpl.java fe7ee1e
Diff: https://reviews.apache.org/r/27979/diff/
Testing (updated)
-------
Tested on master, 4.4 and 4.5 branches. But then during the review time I had
to re-prepare the patch and it become compatible only for master branch.
If you accept the patch, could you also cherry-pick my commit to 4.4 and 4.5
branches? (there will be 1 one-line conflict to resolve)
Thanks,
Ilia Shakitko
