> On Nov. 27, 2014, 10:15 a.m., Rohit Yadav wrote: > > +1 > > LGTM, if any of the other designated reviewers don't object let's merge > > this on master/4.5; I've already picked/fixed this for 4.3 branch. > > > > Hari - thanks for the patch, I encourage you to use Github Pull Requests in > > future which I find is less painful than using reviewboard. > > Rajani Karuturi wrote: > and also on 4.4 please. since its already on 4.3, it should goto all 4.3+ > releases.
Yes, Hari please send another patch (maybe via Github PR) for 4.4 branch as well? I'll help merging this on 4.5/master in the meanwhile. - Rohit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17941/#review63196 ----------------------------------------------------------- On Nov. 27, 2014, 9:22 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17941/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2014, 9:22 a.m.) > > > Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani > Karuturi. > > > Bugs: CLOUDSTACK-6075 > https://issues.apache.org/jira/browse/CLOUDSTACK-6075 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6075: Increase the ram size for router service offering > Increased the ram size of Internal load balancer vm service offering also > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f > > plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java > 803d3a5 > server/src/com/cloud/configuration/Config.java cd0824e > server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java > 9fb47fd > setup/db/db/schema-442to450.sql 107f10c > > Diff: https://reviews.apache.org/r/17941/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Harikrishna Patnala > >
