----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28750/#review63987 -----------------------------------------------------------
Ship it! a72b6a7f999e028f1056e8aa4c1ef7d2b2f2d3da 4.5 84aaef25d9b86b4b1ac193746a87a3dfc77a9c6f master - SrikanteswaraRao Talluri On Dec. 5, 2014, 10:07 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28750/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 10:07 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8028 > https://issues.apache.org/jira/browse/CLOUDSTACK-8028 > > > Repository: cloudstack-git > > > Description > ------- > > Commit 818957de0c3115250b4dd9e833619be788cd66de added "userdata" key in > "virtual_machine" in test_data.py. > This causes deployment failure for VM in other test cases where the network > in which VM is being deployed does not support UserData service. > > Solution: > Add separate dict for virtual_machine with UserData and change original key > pair value to prior value. Also change test_security_groups.py accordingly. > > > Diffs > ----- > > test/integration/component/test_security_groups.py a644a1c > tools/marvin/marvin/config/test_data.py 232a922 > > Diff: https://reviews.apache.org/r/28750/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Gaurav Aradhye > >
