----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23991/#review64097 -----------------------------------------------------------
Ship it! commited into master. - Pierre-Luc Dion On Dec. 5, 2014, 10:23 p.m., Vincent Bernat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23991/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 10:23 p.m.) > > > Review request for cloudstack and Pierre-Luc Dion. > > > Bugs: CLOUDSTACK-7195 > https://issues.apache.org/jira/browse/CLOUDSTACK-7195 > > > Repository: cloudstack-git > > > Description > ------- > > Some try/except in security_group.py catch a lot of exceptions. There > was already one fixed in CLOUDSTACK-1052. Here is another one. We use > logging.exception() to log those exceptions. > > > Diffs > ----- > > scripts/vm/network/security_group.py 704b27982021 > > Diff: https://reviews.apache.org/r/23991/diff/ > > > Testing > ------- > > > Thanks, > > Vincent Bernat > >
