Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/9#issuecomment-66134697 Hi Rohit, Well there are a couple of things here: 1st: I work on a fork and pull in upstream master and merge that into ovmsupport (https://github.com/snuf/cloudstack/tree/ovmsupport) so in principle that makes the ovmsupport tree aligned with master including my patches. 2nd: Test coverage on part of the code is 81% (the object branch, supportive translation layer to communicate with Ovm3) and on part not where I want it to be (the hypervisor branch, where integration with Cloudstack lives). 3rd: It works within the boundaries of the feature design doc on wiki, which means all basic stuff works but some features can not be provided as Ovm3 doesnât support them with the storage backend (running snapshots for example). 4th: The systemvm.img thatâs generated from buildsystemvm.sh is a raw image so can be used for the systemvms for Ovm3. Does this answer your question ? I genuinely think there should be some coverage for the integration layer into Cloudstack which is kind of absent? Cheers, Funs On 06 Dec 2014, at 14:02, Rohit Yadav <notificati...@github.com> wrote: > That's great Funs. I see it's already passing smoke tests on TravisCI so we can merge it on master whenever you advise? If it's functionally working with good enough coverage and tests I would say go ahead and merge it on master right away. > > â > Reply to this email directly or view it on GitHub. >
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---